Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for upgrading librespot to v0.2.0 #969

Closed
JojiiOfficial opened this issue Jun 17, 2021 · 3 comments · Fixed by #977
Closed

Tracking issue for upgrading librespot to v0.2.0 #969

JojiiOfficial opened this issue Jun 17, 2021 · 3 comments · Fixed by #977
Labels
dependencies Pull requests that update a dependency file enhancement A new feature that would improve Spotifyd refactor Code changes that do not effect the functionality wontfix Issues that will not be fixed under any circumstances

Comments

@JojiiOfficial
Copy link
Member

As mentioned in #717 here the tracking issue for upgrading librespot to v0.2.0

closes #717 #945

@JojiiOfficial JojiiOfficial added enhancement A new feature that would improve Spotifyd refactor Code changes that do not effect the functionality dependencies Pull requests that update a dependency file labels Jun 17, 2021
@capnfabs
Copy link
Contributor

capnfabs commented Jul 5, 2021

Hey! I started work on this a few weeks ago for a hobby project (video); the upgrade work is by no means complete yet, but wanted to link it here in case it's helpful to someone as a reference for a cleaner PR.

Current status: it works, but:

  • it panic whenever you try to quit with Ctrl C (this is probably easy to fix, I just haven't done it yet)
  • dbus is a bit complicated. The dbus libraries changed significantly as part of supporting tokio 1.0, which is required for librespot v0.2.0. I'd wanted to rework the current dbus_mpris implementation anyway -- would be nice to support property change signals, and to not hit the Spotify API on every dbus property fetch -- so I've been doing it in the same branch so that I can use dbus_crossroads, which seems to be the "newer" way of implementing a DBUS server.
  • I've ignored automated tests so far.

Code is here: master...capnfabs:fabian/wip-big-upgrade

Would you be open to reworking DBUS and doing the upgrade in the same PR? I would normally try and do the minimal possible upgrade in a PR, but am very much not doing this in the code on that branch.

@capnfabs
Copy link
Contributor

Cleaned up that branch a bit, fixed the Ctrl C issue, and pushed it to #977

@stale
Copy link

stale bot commented Oct 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issues that will not be fixed under any circumstances label Oct 9, 2021
@stale stale bot closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement A new feature that would improve Spotifyd refactor Code changes that do not effect the functionality wontfix Issues that will not be fixed under any circumstances
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants