Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use user_url if specified by user when running cruise #1454

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Dec 31, 2024

Important

Prioritize user_url over generated URL in initialize_observer_cruise in observer_service.py.

  • Behavior:
    • In initialize_observer_cruise in observer_service.py, prioritize user_url over metadata_response URL when setting url.
    • Raises UrlGenerationFailure if neither user_url nor metadata_response URL is available.

This description was created by Ellipsis for e2353ae. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e2353ae in 9 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_tZiifNViogrc5eQD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 24352f5 into main Dec 31, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/use_user_url_observer_cruise branch December 31, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant