Backup Restore Sort Alpha #8792

BKSteve · 2024-09-01T16:21:17Z

fix the sort order of folders backup, restore, root directories settings.

Can't get it to display filenames for restore.

Summary by CodeRabbit

New Features
- Improved data processing logic for better organization of folders and files in the file browser interface.
- Enhanced sorting of items to present folders and files in alphabetical order for a more user-friendly experience.
Bug Fixes
- Added logging for received data to aid in debugging and tracking input during execution.

coderabbitai · 2024-09-01T16:22:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes enhance the data processing logic in browser.js by introducing structured handling of input data. The code now logs received data for debugging, separates items into folders and files, sorts them alphabetically, and concatenates them into a single array. This results in improved organization of the displayed data in the file browser interface.

Changes

Files	Change Summary
sickchill/gui/slick/js/browser.js	Enhanced data processing logic to log input data, categorize items into folders and files, sort them alphabetically, and concatenate into a single array.

Poem

In the browser where data flows,
Folders and files in neat little rows.
Sorted and logged, oh what a sight,
A tidy display, all shining bright!
Hops of joy for changes made,
A happy rabbit in the shade! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

BKSteve · 2024-09-01T16:24:52Z

@coderabbitai review

coderabbitai · 2024-09-01T16:24:56Z

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

sickchill/gui/slick/js/browser.js (1)
39-40: LGTM! But use single quotes for strings to maintain code style consistency.

The code change is approved. Logging the received data aids in tracking the input during execution.

Apply this diff to use single quotes for the string:
-            console.log("Received data:", data);
             console.log('Received data:', data);
Tools

GitHub Check: Test (ubuntu-latest, 3.11, false)

[failure] 40-40:
Strings must use singlequote.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f40d45b and e287884.

Files selected for processing (1)

sickchill/gui/slick/js/browser.js (1 hunks)

Additional context used

GitHub Check: Test (ubuntu-latest, 3.11, false)

sickchill/gui/slick/js/browser.js

[failure] 40-40:
Strings must use singlequote.

Additional comments not posted (3)

sickchill/gui/slick/js/browser.js (3)

42-45: LGTM!

The code changes are approved. Separating the input data into folders and files using the filter method introduces a structured approach to handle the data.

47-49: LGTM!

The code changes are approved. Sorting the folders and files alphabetically based on the name property ensures that they are presented in a user-friendly manner.

51-52: LGTM!

The code changes are approved. Concatenating the sorted folders and files arrays into a single array improves the organization of the data being processed.

cut down code

BKSteve · 2024-09-03T14:59:26Z

I forced zip fileType as a default I couldn't find where this is defined in config_backuprestore to send zip so put it as default setting.

BKSteve · 2024-09-03T17:19:27Z

@miigotu input / feedback on this?

BKSteve · 2024-09-21T07:01:30Z

@coderabbitai configuration

coderabbitai · 2024-09-21T07:01:34Z

CodeRabbit configuration

language: en-US
tone_instructions: ''
early_access: false
enable_free_tier: true
reviews:
  profile: chill
  request_changes_workflow: false
  high_level_summary: true
  high_level_summary_placeholder: '@coderabbitai summary'
  auto_title_placeholder: '@coderabbitai'
  review_status: true
  poem: true
  collapse_walkthrough: false
  sequence_diagrams: true
  changed_files_summary: true
  labeling_instructions: []
  path_filters: []
  path_instructions: []
  abort_on_close: true
  auto_review:
    enabled: true
    auto_incremental_review: true
    ignore_title_keywords: []
    labels: []
    drafts: false
    base_branches: []
  tools:
    shellcheck:
      enabled: true
    ruff:
      enabled: true
    markdownlint:
      enabled: true
    github-checks:
      enabled: true
      timeout_ms: 95000
    languagetool:
      enabled: true
      enabled_only: false
      level: default
    biome:
      enabled: true
    hadolint:
      enabled: true
    swiftlint:
      enabled: true
    phpstan:
      enabled: true
      level: default
    golangci-lint:
      enabled: true
    yamllint:
      enabled: true
    gitleaks:
      enabled: true
    checkov:
      enabled: true
    detekt:
      enabled: true
    eslint:
      enabled: true
    rubocop:
      enabled: true
    buf:
      enabled: true
    regal:
      enabled: true
    actionlint:
      enabled: true
    pmd:
      enabled: true
    cppcheck:
      enabled: true
    semgrep:
      enabled: true
    circleci:
      enabled: true
chat:
  auto_reply: true
knowledge_base:
  opt_out: false
  learnings:
    scope: auto
  issues:
    scope: auto
  jira:
    project_keys: []
  linear:
    team_keys: []
  pull_requests:
    scope: auto

Sort alpha

e287884

coderabbitai bot reviewed Sep 1, 2024

View reviewed changes

BKSteve added 4 commits September 2, 2024 17:17

Sort alpha

8dbeae8

sorting force zip

535dcea

clean up

2b707bf

cut down code

select the file

520fa5a

select the file

c9dd753

BKSteve added 4 commits September 7, 2024 15:21

restore inc zip

30047a8

restore core inc zip

fa53c1a

restore core inc zip

f7fba37

Merge remote-tracking branch 'origin/develop' into browser

0ba0b4d

miigotu merged commit 74ce06f into develop Oct 7, 2024
11 checks passed

miigotu deleted the browser branch October 7, 2024 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backup Restore Sort Alpha #8792

Backup Restore Sort Alpha #8792

BKSteve commented Sep 1, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 1, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

BKSteve commented Sep 1, 2024

coderabbitai bot commented Sep 1, 2024

coderabbitai bot left a comment

BKSteve commented Sep 3, 2024

BKSteve commented Sep 3, 2024

BKSteve commented Sep 21, 2024

coderabbitai bot commented Sep 21, 2024

Backup Restore Sort Alpha #8792

Backup Restore Sort Alpha #8792

Conversation

BKSteve commented Sep 1, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Sep 1, 2024 • edited Loading

Review skipped

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

BKSteve commented Sep 1, 2024

coderabbitai bot commented Sep 1, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

BKSteve commented Sep 3, 2024

BKSteve commented Sep 3, 2024

BKSteve commented Sep 21, 2024

coderabbitai bot commented Sep 21, 2024

BKSteve commented Sep 1, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 1, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)