Improved guess_sep() function to detect ';' and use less mem #842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some CSV docs that use
';'
as a separator, but I don't have control of the source generating them, thus it is out of my control which separator they use.I need the library to correctly guess it.
The previous version of
guess_sep()
doesn't ever detect';'
.Plus I improved memory consumption of the function. It was counting all chars from the sample (max. 1024), but now it just counts the number of
','
,'\t'
and';'
.