Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/theme implementation #66

Merged
merged 1 commit into from
May 29, 2014
Merged

Style/theme implementation #66

merged 1 commit into from
May 29, 2014

Conversation

elad
Copy link

@elad elad commented May 29, 2014

Initial implementation of style/theme parsing, following your input.

Experimental and guarded by the cellStyles option (default: false)

Addresses issue #36

@SheetJSDev
Copy link
Contributor

@elad good start!

I added a few test files. In particular, take a look at https://github.com/SheetJS/test_files/raw/master/cell_style_simple.xlsx -- this has a few column styles as well as row styles, block styles and individual cell styles. Do the colors roughly line up with the sheet?

After doing all of that, please squash to one commit :)

@elad
Copy link
Author

elad commented May 29, 2014

I just realized that I only took care of fgColor and the test file had grids that required bgColor as well. After adding it, I think the colors match.

@elad
Copy link
Author

elad commented May 29, 2014

I think I managed to squash it... Had to merge master though otherwise it wouldn't let me push.

@SheetJSDev
Copy link
Contributor

@elad Your log still shows 8 commits. You should only end up with one commit. You might need to do a git rebase followed by a git push -f.

@elad
Copy link
Author

elad commented May 29, 2014

And now?

@SheetJSDev
Copy link
Contributor

Now we are down to one :)

Clean up the git message (fortunately this is just git commit --amend)

@elad
Copy link
Author

elad commented May 29, 2014

Done. :)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 68dfb49bfa0b26971d259aa4b218a84e48c95fa0 on elad:master into * on SheetJS:master*.

Huge thanks to @SheetJS for guidance on how to do all of this!

Experimental, guarded by the cellStyles option (default: false)
SheetJSDev added a commit that referenced this pull request May 29, 2014
Style/theme implementation
@SheetJSDev SheetJSDev merged commit c91e94d into SheetJS:master May 29, 2014
@SheetJSDev
Copy link
Contributor

@elad thank you very very much :)

@elad
Copy link
Author

elad commented May 29, 2014

You're welcome! Thank you for working on such a fantastic project! :)

clarketm pushed a commit to clarketm/js-xlsx that referenced this pull request Nov 27, 2016
- parse_XFExtGradient stubbed (fixes SheetJS#62, h/t @oakuraape)
- default to UTF16LE (fixes SheetJS#64, h/t @ajuhos)
- ensure that date1904 is propagated to SSF (fixes SheetJS#66, h/t @Martin-Pitt)
- pin CFB version in anticipation of future changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants