Fix repeated columns handling in ODS. #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ziacik The cell object |
|
Hi. Added simple cloning of the cell object. |
1 similar comment
|
I have confirmed that this patch works for my tests |
saarCiklum
referenced
this pull request
in Folcon/js-xlsx
Aug 17, 2020
- README and example cleanup - basic XLSB and ODS write support - flow typecheck for ODS file Note: xlsx.js flow fails: facebook/flow#380 - exposed jszip compression (fixes SheetJS#220, closes SheetJS#284) README issues: | id | author | comment | |-----:|:---------------|:---------------------------------------------| | SheetJS#202 | @sao93859 | closes SheetJS#202 | | SheetJS#211 | @alexanderchan | closes SheetJS#211 corrected examples | | SheetJS#327 | @cskaandorp | changed saveAs example to match write tests | | SheetJS#424 | @dskrvk | added note about s2roa h/t @LeonardoPatignio | | SheetJS#496 | @jimmywarting | closes SheetJS#496 adapted rABS examples with rAAS | ODS file format issues: | id | author | comment | |-----:|:---------------|:---------------------------------------------| | protobi#148 | @user4815162342| closes protobi#148 h/t @ziacik | | protobi#166 | @paulproteus | closes protobi#166 rudimentary ODS write support | | protobi#177 | @ziacik | closes protobi#177 | | protobi#179 | @ziacik | closes protobi#179 use JSON when available | | SheetJS#317 | @ziacik | closes SheetJS#317 | | SheetJS#328 | @think01 | closes SheetJS#328 | | SheetJS#383 | @mdamt | closes SheetJS#383 duplicate cells should be copied | | SheetJS#430 | @RB-Lab | closes SheetJS#430 | | SheetJS#546 | @lgodard | closes SheetJS#546 thanks to other changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Please review the changes I believe fix issue #177
Sorry for not including some unit tests.