Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in README.md? #327

Closed
cskaandorp opened this issue Dec 1, 2015 · 3 comments
Closed

Typo in README.md? #327

cskaandorp opened this issue Dec 1, 2015 · 3 comments

Comments

@cskaandorp
Copy link

Hi,

Great pacakage. I am a Meteor user and got into a lot of trouble with trying to write a workbook to a blob.
In your description, under Writing Workbooks > Write to binary string, you have this piece of code:

function s2ab(s) {
  var buf = new ArrayBuffer(s.length);
  var view = new Uint8Array(buf);
  for (var i=0; i!=s.length;   i) view[i] = s.charCodeAt(i) & 0xFF;
  return buf;
}

/* the saveAs call downloads a file on the local machine */
saveAs(new Blob([s2ab(wbout)],{type:""}), "test.xlsx")

I am most definitely not an expert!! But the code above did not work. Upon closer inspection I found it curious that 'buf' got returned and not 'view' in s2ab. When I changed buf into view, and removed the array-brackets over s2ab in the saveAs, everything worked.

As I said, I am an amateur, could you please review this?

Thanks,

Casper
@reviewher
Copy link
Contributor

Hello Casper!

The code in the README was taken from http://sheetjs.com/demos/writexlsx.html . Can you check whether that demo works?

Actually, there is one difference in the saveAs line. Can you try:

saveAs(new Blob([s2ab(wbout)],{type:"application/octet-stream"}), "test.xlsx")

@cskaandorp
Copy link
Author

Hey Reviewher,

Thanks for getting back to me. I had this issue in December 2015, in the months after that I kind of ran away from Meteor. Sorry, I can't check try this anymore.

Good luck,

Cspr

SheetJSDev added a commit that referenced this issue Feb 3, 2017
@SheetJSDev
version bump 0.8.2: ODS and cleanup
86d6a09 
- README and example cleanup
- basic XLSB and ODS write support
- flow typecheck for ODS file
  Note: xlsx.js flow fails: facebook/flow#380
- exposed jszip compression (fixes #220, closes #284)

README issues:

|  id  | author         | comment                                      |
|-----:|:---------------|:---------------------------------------------|
| #202 | @sao93859      | closes #202                                  |
| #211 | @alexanderchan | closes #211 corrected examples               |
| #327 | @cskaandorp    | changed saveAs example to match write tests  |
| #424 | @dskrvk        | added note about s2roa h/t @LeonardoPatignio |
| #496 | @jimmywarting  | closes #496 adapted rABS examples with rAAS  |

ODS file format issues:

|  id  | author         | comment                                      |
|-----:|:---------------|:---------------------------------------------|
| #148 | @user4815162342| closes #148 h/t @ziacik                      |
| #166 | @paulproteus   | closes #166 rudimentary ODS write support    |
| #177 | @ziacik        | closes #177                                  |
| #179 | @ziacik        | closes #179 use JSON when available          |
| #317 | @ziacik        | closes #317                                  |
| #328 | @think01       | closes #328                                  |
| #383 | @mdamt         | closes #383 duplicate cells should be copied |
| #430 | @RB-Lab        | closes #430                                  |
| #546 | @lgodard       | closes #546 thanks to other changes          |
@reviewher
Copy link
Contributor

@cskaandorp what a glowing recommendation of meteor /s We'll wait for the next report

saarCiklum pushed a commit to Folcon/js-xlsx that referenced this issue Aug 17, 2020
@SheetJSDev @saarCiklum
version bump 0.8.2: ODS and cleanup
447e01c 
- README and example cleanup
- basic XLSB and ODS write support
- flow typecheck for ODS file
  Note: xlsx.js flow fails: facebook/flow#380
- exposed jszip compression (fixes SheetJS#220, closes SheetJS#284)

README issues:

|  id  | author         | comment                                      |
|-----:|:---------------|:---------------------------------------------|
| SheetJS#202 | @sao93859      | closes SheetJS#202                                  |
| SheetJS#211 | @alexanderchan | closes SheetJS#211 corrected examples               |
| SheetJS#327 | @cskaandorp    | changed saveAs example to match write tests  |
| SheetJS#424 | @dskrvk        | added note about s2roa h/t @LeonardoPatignio |
| SheetJS#496 | @jimmywarting  | closes SheetJS#496 adapted rABS examples with rAAS  |

ODS file format issues:

|  id  | author         | comment                                      |
|-----:|:---------------|:---------------------------------------------|
| protobi#148 | @user4815162342| closes protobi#148 h/t @ziacik                      |
| protobi#166 | @paulproteus   | closes protobi#166 rudimentary ODS write support    |
| protobi#177 | @ziacik        | closes protobi#177                                  |
| protobi#179 | @ziacik        | closes protobi#179 use JSON when available          |
| SheetJS#317 | @ziacik        | closes SheetJS#317                                  |
| SheetJS#328 | @think01       | closes SheetJS#328                                  |
| SheetJS#383 | @mdamt         | closes SheetJS#383 duplicate cells should be copied |
| SheetJS#430 | @RB-Lab        | closes SheetJS#430                                  |
| SheetJS#546 | @lgodard       | closes SheetJS#546 thanks to other changes          |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cskaandorp @reviewher