Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format agent copy and equality methods #6119

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jrackham-mo
Copy link

🚀 Pull Request

Description

Closes #6108.
Adds a copy method to FormatAgent, which creates a new FormatAgent from the format specs. Also adds an equality method which compares the format specs.

The use case for this is to temporarily modify the FORMAT_AGENT in a custom load, and then restore it so that we don't change standard iris.load behaviour outside of the custom load.

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (b8f554f) to head (999877a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6119    /-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          88       88           
  Lines       23026    23030     4     
  Branches     5036     5036           
=======================================
  Hits        20672    20676     4     
  Misses       1623     1623           
  Partials      731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…nto add-format-agent-copy

* 'add-format-agent-copy' of github.com:jrackham-mo/iris:
  [pre-commit.ci] auto fixes from pre-commit.com hooks
@jrackham-mo jrackham-mo marked this pull request as ready for review August 15, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Comparisons for FormatAgent()
2 participants