Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #6033

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 87c2c4a to 03282a5 Compare July 8, 2024 17:48
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (8a15e4a) to head (70c7c42).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6033    /-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          88       88           
  Lines       23026    23026           
  Branches     5036     5036           
=======================================
  Hits        20672    20672           
  Misses       1623     1623           
  Partials      731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 075b5b2 to 06741b7 Compare July 15, 2024 18:00
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from e302879 to 853d43a Compare July 22, 2024 18:02
@pp-mo
Copy link
Member

pp-mo commented Jul 23, 2024

This is a bit weird.

(1) The ruff errors are clear enough : it now doesn't like file.readlines(), so can be removed.
see : a7db47f

but
(2) MyPy is complaining about Missing positional argument "self" in call to "__call__" of "_Wrapped", applying in various places where iris-something.name() is called.

This seems like a bug in MyPy, either that or "wraps" is not doing its job properly ?
I think it may be python/mypy#17166
A prototype fix : bd142d3

@pp-mo
Copy link
Member

pp-mo commented Jul 23, 2024

@bjlittle can you re-review this let me know what you think ?

Hint : you might think the MyPy workaround is a bit nasty.
But right now I'm not really sure what would be better (!)

@bjlittle bjlittle force-pushed the pre-commit-ci-update-config branch from bd142d3 to 31573c1 Compare July 27, 2024 11:38
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 31573c1 to bba2f0a Compare July 29, 2024 18:04
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 89bac51 to 4aae96b Compare August 5, 2024 18:14
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.10 → v0.5.7](astral-sh/ruff-pre-commit@v0.4.10...v0.5.7)
- [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/asottile/blacken-docs: 1.16.0 → 1.18.0](adamchainz/blacken-docs@1.16.0...1.18.0)
- [github.com/pre-commit/mirrors-mypy: v1.9.0 → v1.11.1](pre-commit/mirrors-mypy@v1.9.0...v1.11.1)
- [github.com/numpy/numpydoc: v1.7.0 → v1.8.0](numpy/numpydoc@v1.7.0...v1.8.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from ad0c79c to 4723118 Compare August 12, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants