Faster time coordinate categorization #5999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5999 /- ##
==========================================
- Coverage 89.75% 89.75% -0.01%
==========================================
Files 90 90
Lines 22929 22928 -1
Branches 5020 5021 1
==========================================
- Hits 20580 20579 -1
Misses 1618 1618
Partials 731 731 ☔ View full report in Codecov by Sentry. |
|
Would it make sense to add the example code above as a benchmark? |
bouweandela
commented
Jul 3, 2024
| @@ -42,7 51,11 @@ def add_categorised_coord(cube, name, from_coord, category_function, units="1"): | |||
| coordinate point-value. | |||
| units : str, default="1" | |||
| Units of the category value, typically 'no_unit' or '1'. | |||
|
|
|||
| category_function_expects_date : bool, default=False | |||
There was a problem hiding this comment.
As an alternative to adding this extra argument, I could also add a new function add_categorised_time_coord. This function could then also take a simpler category_function argument, which would accept a function with only the point value argument, as the coord argument is no longer needed in any of the time categorization functions below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Make time coordinate categorization faster by converting the time points to datetimes in a single call.
Example script:
while with the current
mainbranch, the timing result isConsult Iris pull request check list
Add any of the below labels to trigger actions on this PR: