Partial collapse of multi-dim string coords: take 2 #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5955 /- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 88 88
Lines 23056 23060 4
Branches 5027 5031 4
=======================================
Hits 20700 20704 4
Misses 1624 1624
Partials 732 732 ☔ View full report in Codecov by Sentry. |
rcomer
commented
May 15, 2024
|
For reference, here is what we currently use for string coordinates in iris/lib/iris/analysis/__init__.py Lines 2437 to 2460 in 95b7ffe |
rcomer
force-pushed
the
collapse-2d-string-coord-untyped
branch
from
0079245
to
638d491
Compare
|
Thanks @stephenworsley! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This is the same bugfix as #4294. In there, I also tried to add type hints following my interpretation of the dev guide. This turned out to be complicated and I suspect is the main reason the PR has not made progress.
I think it would be good to fix the bug regardless of typing questions, so here is a version without the type hints which I'm hoping will be an easier review.
Fixes #3653.
If you have a 2D string coordinate on a cube, and collapse one of the dimensions spanned by that coordinate, the coordinate's points (and bounds, if any) are now serialised along the collapsed dimension. This seems to have been missed when partial collapse was implemented for the numeric coordinates.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: