-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebuild runner needs to read error messages from osd.py(runner) #1746
Comments
Shouldn't the The |
Right, and I'm inclined to rework that..
It still needs context, I think the discussion we'll have about module return types for deepsea-next will have some influence on that. |
When running a salt-run rebuild.node operation which fails before unmounting the drive but after zapping it we have stale data from
osd.list
(minion module).The
osd.remove
func will raise an Exception [OSDNotFound] that needs to be handled by this function.Otherwise the rebuild runner just exits with:
I also noted that the rebuild runner in
master
is not the same as inSES6
. That needs to be forwardported eventually.The text was updated successfully, but these errors were encountered: