Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose NoSharing type through a simple API for external usage. Implement some more general entity and node counting APIs. #238

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

wrtobin
Copy link
Collaborator

@wrtobin wrtobin commented Jul 3, 2019

No description provided.

William Tobin added 2 commits July 3, 2019 11:59
…gleton because it is effectively a state-less functor, and modify countEntitiesOfType to allow counting based on Sharings without changing the API semantics
…node counts for fields, or just meshes with fieldshapes, also adding basic testing of the functions
@wrtobin wrtobin requested a review from cwsmith July 3, 2019 17:44
@wrtobin
Copy link
Collaborator Author

wrtobin commented Jul 3, 2019

I'm not gonna merge this in until we're sure it won't cause any issues with the accidental merge and the revert of PR #236 (#237).

@wrtobin
Copy link
Collaborator Author

wrtobin commented Jul 3, 2019

Forgetting the test case .cc file would've broken everything anyway. At least Travis catches this when I PR on the correct branch....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant