fix(ConfigManager): Resolve ESM import exception on Windows #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
config-manager-import-win32
branch
from
9527181 to
954ead3
Compare
import(path) does not accept absolute Windows-paths since those seem to get confused with URLs. Before, this was mitigated by always calculating a relative path (relative to the UI5 linter install directory). This however breaks on Windows if the target project is located on another drive as reported in #458 Instead convert all paths to "file://"-URLs before passing them to import(). Also, in linter.ts, enforce the project root path to always be absolute to simplify handling the path later on. Resolves #458
RandomByte
force-pushed
the
config-manager-import-win32
branch
from
954ead3 to
15b7d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import(path)does not accept absolute Windows-paths since those seem to get confused with URLs.Before, this was mitigated by always calculating a relative path (relative to the UI5 linter install directory). This however breaks on Windows if the target project is located on another drive as reported in #458
Instead convert all paths to
file://-URLs before passing them toimport().Also, in linter.ts, enforce the project root path to always be absolute to simplify handling the path later on.
Resolves #458