Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detect deprecations in ManagedObject metadata #349

Merged
merged 33 commits into from
Oct 16, 2024
Merged

feat: Detect deprecations in ManagedObject metadata #349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift click to select a range
86a207b
test: Add test cases
d3xter666 Oct 7, 2024
9cde1b8
feat: Add more test cases
d3xter666 Oct 7, 2024
ce4760e
feat: Add scrap deprecations info from api.json
d3xter666 Oct 9, 2024
ffd75cd
feat: Lint deprecations in ManagedObject's metadata
d3xter666 Oct 9, 2024
e96ccd7
fix: Add also "fields" into the deprecations
d3xter666 Oct 9, 2024
856e32c
fix: Types & code
d3xter666 Oct 9, 2024
021d4bb
fix: Add api-deprecations data to the tests
d3xter666 Oct 9, 2024
4bd2a02
test: Update snapshots
d3xter666 Oct 9, 2024
d7ff23d
refactor: Limit types for the different cases
d3xter666 Oct 9, 2024
d81a045
refactor: Add deprecation text since
d3xter666 Oct 9, 2024
055a79a
fix: Update details texts
d3xter666 Oct 9, 2024
441f023
feat: Add details info
d3xter666 Oct 9, 2024
1a23683
test: Update snapshots
d3xter666 Oct 9, 2024
1eeb6ac
fix: Resolve merge conflicts
d3xter666 Oct 10, 2024
0516899
refactor: Add specific messages
d3xter666 Oct 10, 2024
3b7515e
fix: Update snapshots
d3xter666 Oct 10, 2024
487bb77
fix: Determine real ancestors of ManagedObject
d3xter666 Oct 10, 2024
1386580
fix: Class extend transpilation detection
d3xter666 Oct 10, 2024
36a2384
test: Update texts
d3xter666 Oct 10, 2024
d480b97
fix: Add missing perf indicator
d3xter666 Oct 11, 2024
a96e9a8
refactor: Merge api-extract.json api-deprecations.json
d3xter666 Oct 11, 2024
eeb12ee
refactor: Reuse api-extract.json
d3xter666 Oct 11, 2024
fd857c2
test: Add case to inherit directly from ManagedObject
d3xter666 Oct 11, 2024
a313eed
feat: Analyze ManagedObject's metadata with own node visitor (#360)
d3xter666 Oct 15, 2024
7320975
fix: Test snapshots
d3xter666 Oct 15, 2024
0bce4c1
refactor: Remove redundant check
d3xter666 Oct 15, 2024
859a255
refactor: Strip complex type definitions
d3xter666 Oct 15, 2024
13854c5
docs: Update comments
d3xter666 Oct 15, 2024
2e51fd2
docs: Update comments
d3xter666 Oct 15, 2024
abaaacd
refactor: Remove redundant code update test snapshots
d3xter666 Oct 15, 2024
e11d4f7
test: Add array param
d3xter666 Oct 15, 2024
eedc8b6
fix: Test formats
d3xter666 Oct 15, 2024
7d5dffb
test: Add var assignment return
d3xter666 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Update snapshots
  • Loading branch information
@d3xter666
d3xter666 committed Oct 16, 2024
commit 3b7515e90cb4dbbf4cb1f686cf01b311efa5c7e9
2 changes: 1 addition & 1 deletion src/linter/ui5Types/SourceFileLinter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 215,7 @@ export default class SourceFileLinter {
if (this.#apiDeprecations.deprecations.classes[nodeType]) {
this.#reporter.addMessage(MESSAGE.DEPRECATED_CLASS, {
className: nodeType,
details: deprecatedTypes[nodeType],
details: this.#apiDeprecations.deprecations.classes[nodeType],
}, node.initializer);
} else if (deprecatedTypes[nodeType]) {
this.#reporter.addMessage(MESSAGE.DEPRECATED_TYPE, {
Expand Down
32 changes: 16 additions & 16 deletions test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,25 468,25 @@ Generated by [AVA](https://avajs.dev).
severity: 2,
},
{
column: 4,
column: 17,
line: 8,
message: 'Use of deprecated property \'sap.ui.commons.FormattedTextViewControl\'',
message: 'Use of deprecated interface \'sap.ui.commons.FormattedTextViewControl\'',
messageDetails: 'Deprecated since 1.38.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 16,
line: 12,
message: 'Use of deprecated property \'sap.f.AvatarShape\'',
message: 'Use of deprecated type \'sap.f.AvatarShape\'',
messageDetails: 'Deprecated since 1.73. Use the sap.m.AvatarShape (https://ui5.sap.com/1.120/#/api/sap.m.AvatarShape) instead.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 27,
line: 14,
message: 'Use of deprecated property \'sap.m.DateTimeInputType\'',
message: 'Use of deprecated type \'sap.m.DateTimeInputType\'',
messageDetails: 'Deprecated since 1.32.8. Instead, use dedicated <code>sap.m.DatePicker</code> and/or <code>sap.m.TimePicker</code> controls.',
ruleId: 'no-deprecated-api',
severity: 2,
Expand All @@ -502,15 502,15 @@ Generated by [AVA](https://avajs.dev).
{
column: 28,
line: 16,
message: 'Use of deprecated property \'sap.m.DateTimeInputType\'',
message: 'Use of deprecated type \'sap.m.DateTimeInputType\'',
messageDetails: 'Deprecated since 1.32.8. Instead, use dedicated <code>sap.m.DatePicker</code> and/or <code>sap.m.TimePicker</code> controls.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 76,
line: 16,
message: 'Use of deprecated property \'Date\'',
message: 'Use of deprecated type \'Date\'',
messageDetails: 'deprecated',
ruleId: 'no-deprecated-api',
severity: 2,
Expand All @@ -526,79 526,79 @@ Generated by [AVA](https://avajs.dev).
{
column: 64,
line: 20,
message: 'Use of deprecated property \'TwoThirds\'',
message: 'Use of deprecated type \'TwoThirds\'',
messageDetails: 'deprecated',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 19,
line: 24,
message: 'Use of deprecated property \'sap.f.Avatar\'',
message: 'Use of deprecated class \'sap.f.Avatar\'',
messageDetails: 'Deprecated since 1.73. Use the sap.m.Avatar (https://ui5.sap.com/1.120/#/api/sap.m.Avatar) instead.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 17,
line: 26,
message: 'Use of deprecated property \'sap.f.Avatar\'',
message: 'Use of deprecated class \'sap.f.Avatar\'',
messageDetails: 'Deprecated since 1.73. Use the sap.m.Avatar (https://ui5.sap.com/1.120/#/api/sap.m.Avatar) instead.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 69,
line: 28,
message: 'Use of deprecated property \'sap.f.IllustratedMessageSize\'',
message: 'Use of deprecated type \'sap.f.IllustratedMessageSize\'',
messageDetails: 'Deprecated since 1.98. Use the sap.m.IllustratedMessageSize (https://ui5.sap.com/1.120/#/api/sap.m.IllustratedMessageSize) instead.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 36,
line: 40,
message: 'Use of deprecated property \'sap.f.Avatar\'',
message: 'Use of deprecated class \'sap.f.Avatar\'',
messageDetails: 'Deprecated since 1.73. Use the sap.m.Avatar (https://ui5.sap.com/1.120/#/api/sap.m.Avatar) instead.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 34,
line: 42,
message: 'Use of deprecated property \'sap.f.Avatar\'',
message: 'Use of deprecated class \'sap.f.Avatar\'',
messageDetails: 'Deprecated since 1.73. Use the sap.m.Avatar (https://ui5.sap.com/1.120/#/api/sap.m.Avatar) instead.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 14,
line: 48,
message: 'Use of deprecated property \'sap.f.DynamicPageTitleArea\'',
message: 'Use of deprecated type \'sap.f.DynamicPageTitleArea\'',
messageDetails: 'Deprecated since 1.54. Consumers of the sap.f.DynamicPageTitle (https://ui5.sap.com/1.120/#/api/sap.f.DynamicPageTitle) control should now use the <code>areaShrinkRatio</code> property instead of the <code>primaryArea</code> property.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 14,
line: 55,
message: 'Use of deprecated property \'sap.f.DynamicPageTitleArea\'',
message: 'Use of deprecated type \'sap.f.DynamicPageTitleArea\'',
messageDetails: 'Deprecated since 1.54. Consumers of the sap.f.DynamicPageTitle (https://ui5.sap.com/1.120/#/api/sap.f.DynamicPageTitle) control should now use the <code>areaShrinkRatio</code> property instead of the <code>primaryArea</code> property.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 15,
line: 61,
message: 'Use of deprecated property \'sap.f.AvatarShape\'',
message: 'Use of deprecated type \'sap.f.AvatarShape\'',
messageDetails: 'Deprecated since 1.73. Use the sap.m.AvatarShape (https://ui5.sap.com/1.120/#/api/sap.m.AvatarShape) instead.',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 30,
line: 73,
message: 'Use of deprecated property \'sap.f.IllustratedMessage\'',
message: 'Use of deprecated class \'sap.f.IllustratedMessage\'',
messageDetails: 'Deprecated since 1.98. Use the sap.m.IllustratedMessage (https://ui5.sap.com/1.120/#/api/sap.m.IllustratedMessage) instead.',
ruleId: 'no-deprecated-api',
severity: 2,
Expand Down
Binary file modified test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap
View file
Open in desktop
Binary file not shown.