Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SAP/ui5-builder
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.5.0
Choose a base ref
...
head repository: SAP/ui5-builder
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.5.1
Choose a head ref
  • 8 commits
  • 61 files changed
  • 2 contributors

Commits on Dec 17, 2020

  1. [INTERNAL] Remove unused fixtures

    @matz3
    matz3 committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    9f29bba View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. [FIX] Windows: Correctly handle project paths containing non-ASCII ch… 

    …aracters

The `slash` module does not convert "extended-length" paths or paths
which contain non-ASCII characters as documented in the modules README:
https://github.com/sindresorhus/slash/blob/7a9158487d8046c13f2de1db7e3734d33bdbb1bd/readme.md#slash-

Since in our case the resulting POSIX paths are only used in our virtual
fs "@ui5/fs", these limitations are not relevent to us.

Therefore we can simply replace any backslashes.

Related to SAP/ui5-fs#294
Resolves SAP/ui5-tooling#469
    @RandomByte
    RandomByte committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    b229bf3 View commit details
    Browse the repository at this point in the history

  2. [INTERNAL] builder: Add integration test for library containing non-A… 

    …SCII characters
    @RandomByte
    RandomByte committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    c38ed63 View commit details
    Browse the repository at this point in the history

  3. [INTERNAL] LibraryFormatter: Add test for library containing non-ASCI… 

    …I characters
    @RandomByte
    RandomByte committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    ad6227f View commit details
    Browse the repository at this point in the history

  4. [INTERNAL] builder: Add integration test for application containing n… 

    …on-ASCII characters
    @RandomByte
    RandomByte committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    bc11033 View commit details
    Browse the repository at this point in the history

  5. [INTERNAL] ApplicationFormatter: Add test for application containing … 

    …non-ASCII characters
    @RandomByte
    RandomByte committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    13001c3 View commit details
    Browse the repository at this point in the history

  6. [INTERNAL] Bump @ui5/fs from 2.0.5 to 2.0.6 

    Changelog of this version: https://github.com/SAP/ui5-fs/blob/v2.0.6/CHANGELOG.md
    @RandomByte
    RandomByte committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    376f4df View commit details
    Browse the repository at this point in the history

  7. Release 2.5.1

    @RandomByte
    RandomByte committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    cced0ad View commit details
    Browse the repository at this point in the history
Loading