[FIX] Warning log of duplicate module declaration

SAP · Feb 28, 2019 · 9a790a3 · 9a790a3
1 parent 6a42786
commit 9a790a3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/lbt/analyzer/JSModuleAnalyzer.js b/lib/lbt/analyzer/JSModuleAnalyzer.js
@@ -398,7 +398,7 @@ class JSModuleAnalyzer {
 					 */
 				} else if ( nModuleDeclarations > 1 && name === info.name ) {
 					// ignore duplicate declarations (e.g. in behavior file of design time controls)
-					log.warn("duplicate declaration of module name at %s", getLocation(args));
+					log.warn(`duplicate declaration of module ${getLocation(args)} in ${name}`);
 				} else {
 					// otherwise it is just a submodule declaration
 					info.addSubModule(name);

diff --git a/lib/lbt/utils/ASTUtils.js b/lib/lbt/utils/ASTUtils.js
@@ -109,8 +109,9 @@ module.exports = {
 	isMethodCall,
 	isNamedObject,
 	isIdentifier,
-	getLocation: function() {
-		return ""; // NODE-TODO
+	getLocation: function(args) {
+		// NODE-TODO include line information in future
+		return args[0].value;
 	},
 	getPropertyKey,
 	findOwnProperty,

diff --git a/test/lib/lbt/utils/ASTUtils.js b/test/lib/lbt/utils/ASTUtils.js
@@ -72,7 +72,7 @@ test("getStringArray", (t) => {
 });
 
 test("getLocation", (t) => {
-	t.deepEqual(ASTUtils.getLocation(), "");
+	t.deepEqual(ASTUtils.getLocation([{value: "module/name"}]), "module/name");
 });
 
 test("getPropertyKey", (t) => {