Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to import webchat for fiori apps #49

Closed
wants to merge 1 commit into from

Conversation

ya332
Copy link

@ya332 ya332 commented Dec 19, 2019

PR for issue #45 . For a fiori app, index.html is the entry point for the app. When one imports the webchat from the cdn, the chatbot UI disappears after the Fiori app renders the views. One has to use the keyword defer to get the webchat after the views are rendered. Docs are missing to mention the distinction of Fiori apps and Non Fiori apps.

@mschleeweiss
Copy link

Hey @ya332, I stumbled upon your solution and don't know if its optimal. Embedding the chatbot into the index.html means it is not usable for launchpad scenarios (apps in the launchpad do not use the index.html but go directly to the Component.js).

JWandrocke added a commit that referenced this pull request May 8, 2020
Fix to set the input focus if the state is Open to avoid stealing foc…
@ya332
Copy link
Author

ya332 commented Jul 4, 2020

Hey @ya332, I stumbled upon your solution and don't know if its optimal. Embedding the chatbot into the index.html means it is not usable for launchpad scenarios (apps in the launchpad do not use the index.html but go directly to the Component.js).

Hello @mschleeweiss , sorry for the late reply. Fiori-like UI5 apps can be configured to have an index.html file. I am not sure if this is going to matter anymore though.

@ya332 ya332 closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants