Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdl: set app name #7370

Merged
merged 1 commit into from
Sep 28, 2024
Merged

sdl: set app name #7370

merged 1 commit into from
Sep 28, 2024
1 −0

Conversation

e2dk4r
Copy link
Contributor

@e2dk4r e2dk4r commented Sep 27, 2024 •
edited
Loading

Ryujinx was not hinting application name, so on some platforms (e.g. Linux) volume control shows Ryujinx as 'SDL Application'. This can cause confusion.

This commit fixes name in volume control applets on some platforms.

see: https://wiki.libsdl.org/SDL2/SDL_HINT_APP_NAME

Changes

$ wpctl status > /tmp/before.txt
$ # After this patch
$ wpctl status > /tmp/after.txt
$ diff -u /tmp/before.txt /tmp/after.txt
-        83. SDL Application                                            
-             86. output_FR       > Generic Analog:playback_FR	[active]
-             87. output_FL       > Generic Analog:playback_FL	[active]
         83. Ryujinx                                                    
              86. output_FR       > Generic Analog:playback_FR	[active]
              87. output_FL       > Generic Analog:playback_FL	[active]

@e2dk4r
sdl: set app name
5d0c51f 
Ryujinx was not hinting application name, so on some platforms (e.g.
Linux) volume control shows Ryujinx as 'SDL Application'. This can cause
confusion.

This commit fixes name in volume control applets on some platforms.

see: https://wiki.libsdl.org/SDL2/SDL_HINT_APP_NAME
@ryujinx-mako ryujinx-mako bot requested a review from a team September 27, 2024 14:27
@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:

Old GUI (GTK3)
GUI-less (SDL2)
Only for Developers

@AcK77 AcK77 merged commit 5dbba07 into Ryujinx:master Sep 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jduncanator jduncanator jduncanator approved these changes

@AcK77 AcK77 AcK77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e2dk4r @jduncanator @AcK77