Add proper underscore handling to float and complex types. #5356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
reviewed
Jul 19, 2024
vm/src/builtins/complex.rs
Outdated
| None => Complex64::new(crate::literal::float::parse_str(s)?, 0.0), | ||
| None => { | ||
| let stripped = float::float_strip_underscores(s.as_bytes())?; | ||
| Complex64::new(crate::literal::float::parse_bytes(&stripped)?, 0.0) |
There was a problem hiding this comment.
is there any case parse_bytes is called without float_strip_underscores?
How about put it in parse_bytes if it is necessary?
There was a problem hiding this comment.
I did not come across any cases where parse_bytes calls needed to or could be performed without underscore handling. I'll look into putting this directly in parse_bytes 👍
|
Thank you! Does parser updated need to be applied here too or separatedly updatable? |
The underline handling is now completely in parser. I removed all changes in this PR made to |
youknowone
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here is a solution proposal for adding correct underscore handling to
vm/src/builtins/float.rsandvm/src/builtins/complex.rs(close #5351 ).