Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: fix fdopen invalid file descriptor #2749

Merged
merged 1 commit into from
Jul 26, 2021
Merged

os: fix fdopen invalid file descriptor #2749

merged 1 commit into from
Jul 26, 2021

Conversation

deantvv
Copy link
Contributor

@deantvv deantvv commented Jul 24, 2021

Related to #1175

vm/src/stdlib/io.rs Outdated Show resolved Hide resolved
@DimitrisJim
Copy link
Member

I can"t see why the test for wasm is error"ing. Could be a dud.

@deantvv
Copy link
Contributor Author

deantvv commented Jul 26, 2021

@youknowone Could you please restart the CI test for macos? It seems that it panic at some weird place which is not related to this PR. Thanks!

@youknowone
Copy link
Member

youknowone commented Jul 26, 2021

@deantvv I think there is an actual bug. Please check @DimitrisJim"s review. It also affect WASM.

See Line 58 of the failing test.

error[E0432]: unresolved import `crate::stdlib::os`
  --> vm/src/stdlib/io.rs:11:20
   |
11 | use crate::stdlib::os::errno_err;
   |                    ^^ could not find `os` in `stdlib`

For local dev environment,

cd wasm/lib && cargo run

@deantvv
Copy link
Contributor Author

deantvv commented Jul 26, 2021

@deantvv I think there is an actual bug. Please check @DimitrisJim"s review. It also affect WASM.

See Line 58 of the failing test.

error[E0432]: unresolved import `crate::stdlib::os`
  --> vm/src/stdlib/io.rs:11:20
   |
11 | use crate::stdlib::os::errno_err;
   |                    ^^ could not find `os` in `stdlib`

For local dev environment,

cd wasm/lib && cargo run

Sorry for this. I fixed this in my local environment but forgot to commit the change.

@youknowone youknowone merged commit cb3d58c into RustPython:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants