Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement os.getpriority and os.setpriority #2453

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Implement os.getpriority and os.setpriority #2453

merged 2 commits into from
Feb 15, 2021

Conversation

kenkoooo
Copy link
Contributor

Implemented os.getpriority and os.setpriority.

Ref: #1175

@kenkoooo kenkoooo mentioned this pull request Feb 13, 2021
Open
@kenkoooo kenkoooo force-pushed the feature/os_get_set_priority branch 2 times, most recently from e9ab804 to ad82f59 Compare February 13, 2021 10:39
@kenkoooo
Copy link
Contributor Author

kenkoooo commented Feb 13, 2021 •
edited
Loading

Since the interface of libc differs between linux-gnu and others, I put duplicated code. If you have any suggestions on this, please let me know.
I use cfg_if! for that. Could you please take a look? Thanks!

@kenkoooo kenkoooo force-pushed the feature/os_get_set_priority branch from ad82f59 to 02c4357 Compare February 13, 2021 15:15
coolreader18
coolreader18 approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you for contributing!

@coolreader18 coolreader18 merged commit c558335 into RustPython:master Feb 15, 2021
@kenkoooo kenkoooo deleted the feature/os_get_set_priority branch February 15, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenkoooo @coolreader18