Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuncArgs kwargs as Option #2289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

youknowone
Copy link
Member

No description provided.

@youknowone youknowone force-pushed the kwargs branch 2 times, most recently from 35ca347 to 503044c Compare March 17, 2021 06:02
@youknowone youknowone changed the title FuncArgs kwargs as optional FuncArgs kwargs as Option Mar 17, 2021
@coolreader18
Copy link
Member

LGTM and I'm not opposed to doing this, but do you have any benchmarks for this? It looks like creating an empty indexmap should be pretty much free, it just needs to call std::collections::hash_map::RandomState::new() which just gets modifies a thread-local variable after the first call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants