Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mini standard library. #2957

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add mini standard library. #2957

wants to merge 1 commit into from

Conversation

P-E-P
Copy link
Member

@P-E-P P-E-P commented Apr 19, 2024

Add a new mini standard library with standard type. This is intended to change and be later replaced with the real standard library.

@P-E-P
Add mini standard library.
56d7a33 
Add a new mini standard library with standard type. This is intended to
change and be later replaced with the real standard library.

libgrust/ChangeLog:

	* libministd/lib.rs: New file.

Signed-off-by: Pierre-Emmanuel Patry <[email protected]>
@P-E-P P-E-P marked this pull request as draft April 19, 2024 18:43
@P-E-P
Copy link
Member Author

P-E-P commented Apr 19, 2024

Compile time is awful and it lacks a bunch of things.

@P-E-P P-E-P requested a review from CohenArthur April 19, 2024 18:44
@P-E-P
Copy link
Member Author

P-E-P commented Apr 19, 2024

Also, we can't even make modules because there is a bug during typechecking with modules. Will open an issue later with a minimized example.

@dkm
Copy link
Member

dkm commented Apr 22, 2024

IIUC, this is mostly some copy/paste adjustment from rustc's libstd? We should probably have matching copyright/license info ?

@P-E-P
Copy link
Member Author

P-E-P commented Apr 22, 2024

IIUC, this is mostly some copy/paste adjustment from rustc's libstd? We should probably have matching copyright/license info ?

I was wondering what should be the appropriate header. It has mostly been copied from rust standard library with some minor adjustments to make crab1 happy. Probably the original license ?

CohenArthur
CohenArthur approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me so far :) we need to discuss how this will be "distributed" within the compiler, and then I think we can merge it and keep adding to it until 14.1

@CohenArthur CohenArthur mentioned this pull request Apr 23, 2024
Draft
@dkm
Copy link
Member

dkm commented Apr 24, 2024

IIUC, this is mostly some copy/paste adjustment from rustc's libstd? We should probably have matching copyright/license info ?

I was wondering what should be the appropriate header. It has mostly been copied from rust standard library with some minor adjustments to make crab1 happy. Probably the original license ?

Maybe add the first part of https://github.com/rust-lang/rust/blob/master/COPYRIGHT in the header. Not sure where to put MIT/APACHE text, but there must be similar case in GCC already

@CohenArthur CohenArthur mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P-E-P @dkm @CohenArthur