Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrubbing through a clip pauses the clip #57

Open
lars-vc opened this issue Sep 5, 2022 · 2 comments
Open

Scrubbing through a clip pauses the clip #57

lars-vc opened this issue Sep 5, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@lars-vc
Copy link

lars-vc commented Sep 5, 2022

Idea

Currently, when you scrub through a clip, the clip will be paused after clicking on the timeline. It would feel more natural that the video keeps playing if the video was playing before the scrub happens.

Issues

If I understand correctly, the current implementation pauses because of performance limitations. I have also encountered issues with this, sometimes after scrubbing and quickly pressing play, the clip will play a second of where you were in the clip before jumping to the correct spot. Sometimes it doesn't even jump at all, this can be fixed by quickly pressing pause and play again, then it will jump.
@Rodeoclash Rodeoclash added the bug Something isn't working label Sep 6, 2022
@Rodeoclash Rodeoclash changed the title [Feat] Scrubbing through a clip pauses the clip Scrubbing through a clip pauses the clip Sep 6, 2022
@Rodeoclash
Copy link
Owner

Rodeoclash commented Sep 6, 2022 •
edited
Loading

You're correct in that this is a limitation of the system as it stands. After clicking to navigate on the timeline, we need to wait to ensure all videos are synced before we can continue playback.

I've made a note in https://github.com/users/Rodeoclash/projects/1/views/1 that this should be one of the considerations in how V2 is designed.

@Rodeoclash
Copy link
Owner

I think it's worth doing a bit more investigation into the current system to see if I can buffer play / pause events to avoid needing to use the play / pause to get things moving again. I'll leave this ticket open until I've investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rodeoclash @lars-vc