Notifications api endpoint #1347
Conversation
KoalaSat
force-pushed
the
notifications-api-endpoint
branch
from
4ff1eb5
to
53a5c84
Compare
| @@ -284,6 284,30 @@ paths: | |||
| type: string | |||
| description: Reason for the failure | |||
| description: '' | |||
| /api/notifications/: | |||
There was a problem hiding this comment.
By running the tests the API schema and redoc docs get updated with the new endpoint 👌
tests/utils/trade.py
Outdated
| path = reverse("notifications") | ||
| params = f"?created_at={created_at}" | ||
| headers = self.get_robot_auth(robot_index, first_encounter) | ||
| self.response = self.client.get(path params, **headers) |
There was a problem hiding this comment.
During tests, trade.response is always the return of the latest GET to /api/order. Maybe here we want to create a new variable on the Trade class. for example: notification . This way, in tests we evaluate (assert) the value of trade.response for the latest state of an order, and of trade.notification for the latest notification, and don't get about what is the type of response.
I would therefore edit this one as:
self.notification = self.client.get(path params, **headers)
notification or last_notification , the one name you prefer!
There was a problem hiding this comment.
I ended up moving it out of Trade, I think it didn't make sense to have it there
tests/test_trade_pipeline.py
Outdated
| @@ -802,6 955,17 @@ def test_taken_order_expires(self): | |||
|
|
|||
| self.assert_order_logs(data["id"]) | |||
|
|
|||
| trade.get_notifications() | |||
| # Checks | |||
| self.assertResponse(trade.response) | |||
There was a problem hiding this comment.
If we use trade.notification as the response stored by the get_notification() method, that will make tests more clear :)
KoalaSat
force-pushed
the
notifications-api-endpoint
branch
from
53a5c84
to
eed8c11
Compare
|
Sorry for the confusion @Reckless-Satoshi 😆 test are not yet ready to be review, I'm investigating a possible wrong test on |
KoalaSat
force-pushed
the
notifications-api-endpoint
branch
4 times, most recently
from
dfd7603
to
28620e9
Compare
KoalaSat
force-pushed
the
notifications-api-endpoint
branch
4 times, most recently
from
08802b5
to
030663b
Compare
KoalaSat
force-pushed
the
notifications-api-endpoint
branch
from
5117dbc
to
4a7a28b
Compare
KoalaSat
force-pushed
the
notifications-api-endpoint
branch
from
c1b4307
to
284d0f4
Compare
KoalaSat
force-pushed
the
notifications-api-endpoint
branch
from
284d0f4
to
326a2f1
Compare
KoalaSat
force-pushed
the
notifications-api-endpoint
branch
from
2930d2b
to
5c08dd3
Compare
What does this PR do?
This PR introduces a new API endpoint for the robot to fetch all notifications sent to it. To reduce bandwidth it allows to filter by the creation date.
A new table Notification has been created to have a place to store these notifications.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.