Fix Telugu regex #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test? |
|
Sure, will do. |
|
I have added a test scenario, but I don't think it is possible for me (not speaking Telugu) to cover all relevant case. I hope that the module will be used in a real world scenario soon, so if anything pops up then, I'll gladly fix it and add the respective tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged in, will fix a bug in the Telugu regular expression that may interpret two consecutive Telugu consonants as one single character although they should be counted as two.
The bug was a missing closing square bracket in the regular expression that did not interfere with identifying all single Telugu characters as such and thus slipped the test.