Add main to work around eslint-plugin-import issues
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte can't upgrade
periscopicdue to import-js/eslint-plugin-import#2132, import-js/eslint-plugin-import#1868, import-js/eslint-plugin-import#1810Alternatively, I could either add
eslintignores everywhere or disable that plugin. Disabling the plugin might not be the worst idea since I'd expect TypeScript to find missing imports, but that won't really work since SvelteKit and Svelte share a config and SvelteKit doesn't use TypeScript. Anyway, this seems easy enough and doesn't seem like a terribly bad idea sincemoduleisn't listed in the officialpackage.jsonspec (https://docs.npmjs.com/cli/v7/configuring-npm/package-json)