Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable path parsing to account for root level paths #1638

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: enable path parsing to account for root level paths #1638

wants to merge 1 commit into from

Conversation

LukeHagar
Copy link

What/Why/How?

Fixes #1634

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@LukeHagar LukeHagar requested a review from a team as a code owner July 18, 2024 07:41
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 2002b9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lornajane
Copy link
Collaborator

Thanks for the pull request @LukeHagar , we'll take a look.

@tatomyr
Copy link
Contributor

tatomyr commented Jul 22, 2024 •
edited
Loading

@LukeHagar do you mind adding a simple e2e test for the case?
(The corresponding folder is __tests__/split).

@LukeHagar
Copy link
Author

I'd be happy too, I realize this solution would also collide with any API endpoints that are actually /root so I'll solve for that as well.

@tatomyr tatomyr marked this pull request as draft August 22, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

root level paths / are not split correctly
3 participants
@LukeHagar @lornajane @tatomyr