Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missalignment in plot of example: examples/basic_examples/Coin Toss Model.ipynb? #324

Closed
juliusaka opened this issue Jul 17, 2024 · 2 comments · Fixed by #333
Closed

missalignment in plot of example: examples/basic_examples/Coin Toss Model.ipynb? #324

juliusaka opened this issue Jul 17, 2024 · 2 comments · Fixed by #333
Labels
good first issue Good for newcomers

Comments

@juliusaka
Copy link

Hi,
I'm trying to understand Bayesian Inference, which is why I look through your examples. In the above mentioned example,
examples/basic_examples/Coin Toss Model.ipynb,
The model is called for inference with
model = coin_model(a=4.0, b = 8.0),
while in the plot at the end the prior is plotted with,
plot!(rθ, (x) -> pdf(Beta(2.0, 7.0), x), fillalpha=0.3, fillrange = 0, label="P(θ)", c=1,).
Can you please clarifiy if that is a missalignment, or help me in my understanding?
Best,
Julius

@bvdmitri
Copy link
Member

Good catch, @juliusaka! You're absolutely right—the plot should use the model's parameters. We likely overlooked this during the example refactoring. Could you prepare a pull request with the fix? It's a great way to contribute to RxInfer!

@mhidalgoaraya
Copy link
Contributor

mhidalgoaraya commented Jul 17, 2024 via email

@albertpod albertpod added the good first issue Good for newcomers label Jul 17, 2024
@juliusaka juliusaka changed the title misslaginment in plot of example: examples/basic_examples/Coin Toss Model.ipynb? missalignment in plot of example: examples/basic_examples/Coin Toss Model.ipynb? Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants