-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missalignment in plot of example: examples/basic_examples/Coin Toss Model.ipynb? #324
Labels
good first issue
Good for newcomers
Comments
Good catch, @juliusaka! You're absolutely right—the |
I am out of the office but for sure I take care of it next week.
…On Wed, 17 Jul 2024 at 11:04, Bagaev Dmitry ***@***.***> wrote:
Good catch, @juliusaka <https://github.com/juliusaka>! You're absolutely
right—the plot should use the model's parameters. We likely overlooked
this during the example refactoring. Could you prepare a pull request with
the fix? It's a great way to contribute to RxInfer!
—
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJSD34JFWGGYZ5GQNTRNBCLZMYXSNAVCNFSM6AAAAABLABQCHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSHAYDOMRVGE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
juliusaka
changed the title
misslaginment in plot of example: examples/basic_examples/Coin Toss Model.ipynb?
missalignment in plot of example: examples/basic_examples/Coin Toss Model.ipynb?
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I'm trying to understand Bayesian Inference, which is why I look through your examples. In the above mentioned example,
examples/basic_examples/Coin Toss Model.ipynb,
The model is called for inference with
model = coin_model(a=4.0, b = 8.0),
while in the plot at the end the prior is plotted with,
plot!(rθ, (x) -> pdf(Beta(2.0, 7.0), x), fillalpha=0.3, fillrange = 0, label="P(θ)", c=1,)
.Can you please clarifiy if that is a missalignment, or help me in my understanding?
Best,
Julius
The text was updated successfully, but these errors were encountered: