Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictions in the Bike Rental Demand demo are worse than in RxInfer v2 due to factorization constraints #291

Open
bvdmitri opened this issue Apr 12, 2024 · 0 comments · May be fixed by #356
Labels
enhancement New feature or request

Comments

@bvdmitri
Copy link
Member

We knew about this with @albertpod. I'm noting it here so we don't forget. The problem is that in RxInfer v3.0.0, there was a change in how predictions are constrained by default. Before, the where { allow_missing = true } block made sure that data points were connected with other hidden states (jointly distributed). Now, with the factorized = true option in the getorcreate! function of GraphPPL.jl, all data points are separated (mean-field ed).

One possible solution could be to introduce a special structure, let's call it UnfactorizedData, that wraps the data input, allowing us to set factorized = false in the getorcreate! function. For example:

infer(
    model = ...,
    data = (y = UnfactorizedData(missing), ) 
)
@bvdmitri bvdmitri added the enhancement New feature or request label Apr 12, 2024
@bvdmitri bvdmitri added this to the RxInfer 3.1.0 release milestone Apr 12, 2024
@wouterwln wouterwln linked a pull request Sep 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant