Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Two ways to change version in app info screen #1994

Closed
4 tasks done
oSumAtrIX opened this issue Jun 22, 2024 · 5 comments
Closed
4 tasks done

bug: Two ways to change version in app info screen #1994

oSumAtrIX opened this issue Jun 22, 2024 · 5 comments
Assignees
Labels
Bug report Something isn't working ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jun 22, 2024

Bug description

The correct way to "Undo" a choice is to "Go back" to the previous screen. Having a separate setting to change the version doesn't make sense in the sense of a progression:

image

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager
@oSumAtrIX oSumAtrIX added Bug report Something isn't working ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager labels Jun 22, 2024
@Ushie
Copy link
Member

Ushie commented Jun 22, 2024

Perhaps this screen should be removed, it serves no purpose, instead the patch selector screen should take it's spot instead and from there we can arrive at the patching process

@oSumAtrIX
Copy link
Member Author

Makes sense, although having an "Overview" before starting to patch is good. Mabe after the patch selector?

@Ushie
Copy link
Member

Ushie commented Jun 22, 2024

Oh, I remember why we didn't want to throw the user into the patches screen

The user is expected to use the default selection of patches, making the patch selection page a forced step in the flow may cause the user to meddle when they don't really know what they're doing, those who want to change things will know how to, without adding an unnecessary step to the masses and making them think they have to do something

@oSumAtrIX
Copy link
Member Author

A recommended Skip (Fab) button can be added

@Axelen123
Copy link
Member

This issue will be dealt with by the downloader plugin branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
Status: Done
Development

No branches or pull requests

4 participants