Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message for unmatched patterns() in melt() #3107

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Better error message for unmatched patterns() in melt() #3107

merged 2 commits into from
Oct 18, 2018

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Oct 12, 2018 •
edited by mattdowle
Loading

Closes #3106

@codecov
Copy link

codecov bot commented Oct 12, 2018 •
edited
Loading

Codecov Report

Merging #3107 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3107       /-   ##
==========================================
  Coverage   90.97%   90.99%    0.01%     
==========================================
  Files          61       61              
  Lines       11844    11845        1     
==========================================
  Hits        10775    10778        3     
  Misses       1069     1067       -2
Impacted Files Coverage Δ
R/fmelt.R 100% <100%> ( 4.87%) ⬆️
src/fsort.c 73.93% <0%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd93a06...1bed123. Read the comment docs.

@MichaelChirico
Copy link
Member Author

poking around coverage a bit, i notice a bunch of misses appear to be around "internal error"s like:

https://codecov.io/gh/Rdatatable/data.table/src/cd93a0642f51044adccaf36fea84acac4c85d3fa/src/ijoin.c

Should we #nocov these errors? Seeing as how the whole point of them is that we don't know how any use case could end up there..

@mattdowle mattdowle changed the title Closes #3106, better error message for unmatched patterns() in melt() Better error message for unmatched patterns() in melt() Oct 18, 2018
@mattdowle mattdowle added this to the 1.12.0 milestone Oct 18, 2018
@mattdowle mattdowle merged commit 5ec2fb1 into master Oct 18, 2018
@mattdowle mattdowle deleted the melt_unmatched_patterns branch October 18, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelChirico @mattdowle