Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assigning NULL to missing column when providing i too #3090

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Assigning NULL to missing column when providing i too #3090

merged 1 commit into from
Oct 2, 2018

Conversation

mattdowle
Copy link
Member

Closes #3089

@mattdowle mattdowle added this to the 1.12.0 milestone Oct 2, 2018
@codecov
Copy link

codecov bot commented Oct 2, 2018 •
edited
Loading

Codecov Report

Merging #3090 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3090    /-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          61       61           
  Lines       11813    11813           
=======================================
  Hits        10737    10737           
  Misses       1076     1076
Impacted Files Coverage Δ
src/assign.c 94.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e88b0...0caed3c. Read the comment docs.

@mattdowle mattdowle merged commit c968304 into master Oct 2, 2018
@mattdowle mattdowle deleted the null_column branch October 2, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mattdowle