Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I see you’re also a Nix user! Unfortunately some assumptions about Nixpkgs’s strange macOS OpenGL setup were baked into the code, so your project couldn’t be built on macOS without Nix, and a pull request I’m working on to clean them up in Nixpkgs broke the build there too. I’ve fixed those issues here, along with a couple others, and will be incorporating the patch into the Nixpkgs package for now.
By the way, it’d technically be better to use
dependency('gl')
instead, because Meson has special handling for this string. Unfortunately, because of the aforementioned Nixpkgs OpenGL weirdness, this produces a non‐functional build with the current stable Nixpkgs release. You might want to consider making that change after the current release is out of support, if you spend any time on this codebase in future.