Call finalizeCellEditing() before switching tokenTypes to make sure t… #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat all cell editings are applied before switching the token tables. fixes RPTools#4650
cwisniew
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #4650
Description of the Change
When switching to another token type, the underlying table data changes. The TableCellEditor is tied to a specific cell though and if it is not closed before changing the underlying data, that can cause data loss and/or NullReferenceExceptions.
The solution is to use the finalizeCellEditing method to close and apply the data before switching the table data.
Possible Drawbacks
No drawbacks known
Release Notes
This change is