Fix onChangeSelection and related events for inactive tabbed frames #4810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For dockable frames, the component itself is hidden if not the active tab so AWT's `isVisible()` returns false. However JIDE and the user consider the frame still open, which agrees with `!isHidden()`.
cwisniew
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4709
Description of the Change
As an AWT component, inactive tabbed frames are considered not visible, so the existing check did not accomodate these. As a JIDE component they are considered not hidden, so we use that property instead.
Possible Drawbacks
If anyone is counting on inactive tabs not generating events, this will shock them.
Documentation Notes
Frames can generate
onChangeSelection,onChangeToken, andonChangeImpersonatedeven when not the active tab.Release Notes
onChange*events.This change is