Add workaround for drag and drop between frames #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reimplements WebView drag and drop without the cache and thus the issue.
cwisniew
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #3679
Description of the Change
This reimplements the WebView drag-and-drop listeners. The behaviour is the same except that we do not cache the mime types and values of a drag operation, meaning we don't have to worry about invalidating the cache on all relevant frames when a drag ends.
I will also be opening a bug ticket with JavaFX so that we can rip this code back out once the underlying issue is fixed.
Possible Drawbacks
More code to maintain for something that's not our fault.
Documentation Notes
N/A
Release Notes
This change is