Update crowdin.yml to extend translation file suffix with locale #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with additional locale identifier (e.g. en, en_au, en_gb)
|
Do we need to rename our existing i18n files with this change? |
|
No. Currently the translated files are written by Crowdin as you see them. At present the en_au and en_gb files are not written because there are three en translations and we only get the one. This should result in the additional translations coming home to daddy. |
kwvanderlinde
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
closes #4344
Description of the Change
Currently Crowdin returns one file for each language using a a two letter code; e.g. _jp, _es, _en
This falls down when there are multiple locale translations that use the same code.
Changing the crowdin.yml export mask from:
translation: /%original_path%/%file_name%_%two_letters_code%.%file_extension%to:
translation: /%original_path%/%file_name%_%locale_with_underscore%.%file_extension%should resolve the issue.
Possible Drawbacks
none foreseeable if it works as expected, otherwise, tragic mayhem.
Documentation Notes
Translation file import fix
Release Notes
Translation file import fix
This change is