Replace token IDs on imported maps #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copy constructor already guarantees that everything has independent copies made - and if it missed something that would be a bug. So it's appealing to use it for map imports where we want the same thing. Also preserve the creation time in the copy constructor when `keepIds` so that it is preserved when campaigns are copied and such. `Zone#import()` no longer needs to do as much. All it does not is clear the initiative list.
ZoneRenderers are not actually being compared based on the creation time. If they were at some point, they aren't anymore. No more need for ZoneRenderer to implement `Comparable<>`.
cwisniew
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4789
Description of the Change
Zones are now copied on import. This has the effect of regenerating all IDs (the zone itself, drawings, tokens). This also reduces the expectations on
Zone#import()as the copy constructor will take of anything that isn't destroying data.Possible Drawbacks
Imported maps can no longer be relied on to keep token IDs. Any maps that contain internal references to specific token IDs will no longer work as they did before and will have to be manually updated.
Documentation Notes
Token IDs cannot be relied on when importing maps since they will be changed to unique values.
Release Notes
This change is