Fix the splash screen to show on its own #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LibraryManager class is really expensive to load, so having it happen at some indeterminate time is not great. Instead we now force it to load as part of the startup sequence.
Problem with URL hashing is that it tries to resolve hostnames, which is a bit excessive.
It has potential to be hit early in the init process, though so far we've dodged it. But there's no point not setting it up right away and just avoiding the whole NPE situation.
This prevents JIDE from forcing the frame opening even though we don't want that. Another option is to set `getDockingManager().setUseFrameBounds(false);` as that also won't cause the frame to show when we load our layout.
cwisniew
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #4782
Description of the Change
Mainly this change delays the JIDE layout load until we want the frame to be made visible. This avoids JIDE foisting a visible frame on us.
Also noticed there were some delays due to built in libraries. Sometimes we would get really unlucky and these would take a long time to load and would do so while we're trying to make our frame visible. To avoid this, we now explicitly init the
LibraryManagerearly in the startup process. Also we no longer hash URLs inStatSheetbecause that does things like hostname lookups.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
This change is