More client lifecycle improvements #4777
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #4776, follow up to PR #4771
Description of the Change
The main change here is the bug fix for #4776:
ServerCommand
will now only send messages if the client has finished its handshake. This is done by givingMapToolClient
an explicit set of states:New
when first created;Started
after the handshake is started on aNew
client;Connected
when the handshake completes for aStarted
client;Closed
wheneverclose()
is called regardless of previous state.Second is that handshakes are future-based now which really cleans up the amount of code dedicated to observer them and getting results.
Third is some minor fixes and clean up related to the player database UI.
Possible Drawbacks
Hopefully none ...
Documentation Notes
N/A
Release Notes
N/A
This change is