Keep GUI class files hygienic #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new approach is as follows: - `compileJava` outputs to a separate directory, so that instrumented and uninstrumented class files are not mixed. - `instrumentForms` syncs the `compileJava` output to the final output directory, then performs instrumentation there. - This task only runs if `compileJava` regenerated any files. - No more defensive deletion of `.class` files via `deleteUiClasses` task.
thelsing
approved these changes
Nov 10, 2023
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Implements #4389
Description of the Change
The key changes are:
compileJavanow outputs.classfiles to a separate directory so that instrumented and uninstrumented files are kept separate.instrumentFormsis now a task that syncs the.classfiles fromcompileJavaover to the final destination, then instruments the files. It also won't run ifcompileJavais up-to-date.The existing
guidesignerplugin was not capable of this, so it has been removed in favour of doing it ourselves.These changes allowed removal of
deleteUiClassesin favour of standard Gradle task dependencies.Possible Drawbacks
There shouldn't be any, though there could still be a (shorter) window of time where a new build can influence an existing instance if built from a changed source set.
Documentation Notes
N/A
Release Notes
This change is