Propagate frame rate cap changes to each ZoneRenderer #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DebounceExecutor` is now able to modify its delay so that existing maps can receive updates to the frame rate cap.
thelsing
approved these changes
Nov 2, 2023
kwvanderlinde
deleted the
bugfix/4335-apply-frame-rate-preference-to-all-maps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4335
Description of the Change
The
DebounceExecutoris now allows its delay to be modified so that existing maps can receive updates to the frame rate cap. Now that the delay can change, it has been made anAtomicLonginstead of a plainlong.Possible Drawbacks
An extra frame can be rendered around the time that the cap is modified.
Documentation Notes
N/A
Release Notes
This change is