Additional JavaScript API Token Functions #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColdAnkles
changed the title
ColdAnkles
force-pushed
the
additional-token-functions
branch
from
9b11d41
to
5cd5c01
Compare
thelsing
reviewed
Oct 14, 2023
src/main/java/net/rptools/maptool/client/script/javascript/api/JSAPIToken.java
Show resolved
Hide resolved
src/main/java/net/rptools/maptool/client/script/javascript/api/JSAPIToken.java
Show resolved
Hide resolved
src/main/java/net/rptools/maptool/client/script/javascript/api/JSAPIToken.java
Show resolved
Hide resolved
src/main/java/net/rptools/maptool/client/script/javascript/api/JSAPIToken.java
Show resolved
Hide resolved
src/main/java/net/rptools/maptool/client/script/javascript/api/JSAPIToken.java
Outdated
Show resolved
Hide resolved
thelsing
approved these changes
Oct 15, 2023
Also store developer options in a separate preference node to keep them separate from regular application preferences. This should make testing and fixups a little easier.
cwisniew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
closes #4322
Description of the Change
Adds additional functions to the JSAPI Token Object to streamline accessing token States and PC/NPC status.
Possible Drawbacks
None
Documentation Notes
Adds functions for getting and setting states, and getting all currently set states. Getting and setting PC/NPC type.
Release Notes
Adds additional token functions to JSAPI Token.
This change is