F4xx SPI Support. Was too easy. didn't get enough time to hate myself and think of a pun #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changed a variable name to better represent what it is.
ol2764RIT
approved these changes
Mar 30, 2024
mjmagee991
approved these changes
Apr 1, 2024
Co-authored-by: Matthew Magee <[email protected]>
…eature/tmb5932/f4xx-SPI
aclowmclaughlin
requested changes
Apr 1, 2024
Got rid of redundant EVT::core::IO. Changed the SPI mode in the configSPI call to an enum to minimize user errors. Changed order in configSPI to be a bool as that is how it is used. minimizes chances of miss input. Updated f3 to also work with the new changes. All of these will be tested to confirm they still work on thurs.
|
@tmb5932 @aclowmclaughlin The changes you made here are fine, but generally, I would like to change the interfaces in EVT-core as little as possible. While the goal of this PR was to add F4xx support, it's now going to require every codebase that uses SPI to change their code. One thing here and there isn't a big deal, but if we did this with every driver, we would get bogged down with updating all the repos. That is to say, if you want to change an interface, make a Trello card for it, and we'll keep it in mind. Then, when we have a bunch of interfaces we want to change and we're not likely to race in the near future, we can go through and clean everything up at once |
aclowmclaughlin
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for STM32F446 SPI