feat: add type hints to rdflib.plugins.sparql.{algebra,operators}
#2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220821T2011-com2ann
branch
2 times, most recently
from
e2fb319
to
d0cb519
Compare
More or less complete type hints for `rdflib.plugins.sparql.algebra` and `rdflib.plugins.sparql.operators`. This does not change runtime behaviour. Other changes: - Fixed line endings of `test/test_issues/test_issue1043.py` and `test/test_issues/test_issue910.py`. - Removed a type hint comment that was present in rdflib/plugins/sparql/algebra.py Related issues: - Closes <RDFLib#2029>.
aucampia
force-pushed
the
iwana-20220821T2011-com2ann
branch
from
d0cb519
to
4a18d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
More or less complete type hints for
rdflib.plugins.sparql.algebraandrdflib.plugins.sparql.operators.This does not change runtime behaviour.
Other changes:
test/test_issues/test_issue1043.pyand
test/test_issues/test_issue910.py.(view diff with https://github.com/RDFLib/rdflib/pull/2094/files?diff=split&w=1 to ignore whitespaces changes which should clean these up)
This is split-off from #1850.
Related issues:
A compact diff with non-runtime aspects stripped out can be found here.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.