fix the implied_bounds_entailment future compatibility lint.
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcnr
changed the title
implied_bounds_entailment lint.implied_bounds_entailment future compatibility lint.
`Any` already requires `'static`
|
Hi @lcnr, Thank you for the fix and the clear example of how this could lead to UB! It seems that by not understanding at the time that Really fantastic to see things like this being systematically addressed. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see rust-lang/rust#105572. Your crate unintentionally relied on a bug in the compiler of Rust itself. This bug is now getting fixed and will be a hard error in a future release.
The issue is that the signature of the impl method differs from the signature of the trait method in a way where the impl would actually have stronger requirements for the caller. This could be use to trigger undefined behavior. https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=71fd0f91713510e75174a5cda4da1edc
The impl requires
T: 'staticbecause'ahas to outlive'staticforBox<dyn Any 'a>asAnyrequiresSelf: 'static.This PR fixes this by adding the
Self: 'staticbound to the impl itself. This bound is required to calldowncastincoalesce_any.Please ask if there are any questions.