Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new ApiVersion 2022-03-21 #1182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

w1lla
Copy link
Contributor

@w1lla w1lla commented Jun 1, 2022

You can still use the old ApiVersion 2013-04-16 by setting it inside the

base.py in settings folder by adding the following line:

DEDICATED = { 'default': { 'HOST': '127.0.0.1', 'PORT': '5008', 'USER': 'SuperAdmin', 'PASSWORD': 'SuperAdmin', 'APIVERSION': '2013-04-16', #2013-04-16 Old APIVERSION for MP. #2022-03-21 New APIVERSION for TM2020 } }

Motivation or cause

{Please write here}

Change description

{Please write here}

Checklist of pull request

Make sure that your pull request follow the following 'rules':

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All new and existing tests passed, except in few situations.
  • My change requires a change to the documentation.

Please leave a comment here if your pull need any updates for the docs or tests.

Additional Comments (optional)

{Please write here}

You can still use the old ApiVersion 2013-04-16 by setting it inside the

base.py in settings folder by adding the following line:

`DEDICATED = {
	'default': {
		'HOST': '127.0.0.1',
		'PORT': '5008',
		'USER': 'SuperAdmin',
		'PASSWORD': 'SuperAdmin',
		'APIVERSION': '2013-04-16', #2013-04-16 Old APIVERSION for MP. #2022-03-21 New APIVERSION for TM2020
	}
}`
@tomvlk tomvlk self-assigned this Sep 14, 2022
@tomvlk tomvlk added this to the Version 0.10.1 milestone Sep 14, 2022
@tomvlk
Copy link
Member

tomvlk commented Sep 14, 2022

I think we already have somewhere a method of setting the api version and the other functions you do, @w1lla

@tomvlk tomvlk added the Blocked label Sep 14, 2022
@tomvlk tomvlk removed this from the Version 0.10.1 milestone Sep 14, 2022
@w1lla
Copy link
Contributor Author

w1lla commented Sep 15, 2022

Hmm where can that be found as i didnt see it

@tomvlk tomvlk added this to the Version 1.0.0 milestone Sep 15, 2022
@tomvlk
Copy link
Member

tomvlk commented Nov 6, 2022

@w1lla do we want this to be a configuration value btw? If so, we have to add it to the default config file inside of the project, or at least make a fallback when you don't set this value at all, right now, what happens when you don't have the value in your configuration file?

@w1lla
Copy link
Contributor Author

w1lla commented Nov 7, 2022

It resorts back to the old 2013-04-16 api version, apparently when you do not set to the newest api version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants