Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary dependencies and move some commands into dev feature #13

Merged
merged 1 commit into from
Mar 27, 2024
Merged

remove unnecessary dependencies and move some commands into dev feature #13

merged 1 commit into from
Mar 27, 2024

Conversation

kamiyaa
Copy link
Contributor

@kamiyaa kamiyaa commented Mar 27, 2024 •
edited
Loading

Tried my best to remove dependencies

  • Moved a bunch of code behind a dev feature flag so users can't use them in the production build
  • Add docker build file for building for Debian Buster
  • Docker image can also be used to run standalone

Running Image

~$ docker run -it --network host --rm coral-cli:latest /app/coral-cli version

Running image with volume to get output

Keygen (with enclave)

~$ docker run -it --network host \
    -v ./output:/app/output --rm \
    coral-cli:latest /app/coral-cli validator keygen \
    --guardian-threshold 1 \
    --module-name 0x5055464645525f4d4f44554c455f300000000000000000000000000000000000 \
    --withdrawal-credentials 0x0100000000000000000000005ee9246f01e95c08ee767029c1d18765bb1779d0 \
    --guardian-pubkeys 0x049cc1fbaa3cffd3e4c1f935c47720d013938ccb822a9cbd20c5f09ab65ae8300e7986b6ce75e916d3b59599ece72134adf2972d06a76a8ba5f3747d356117c342 \
    --fork-version 0x01017000 \
    --enclave-url http://localhost:9001 \
    --output-file output/registration_docker_001.json

Keygen (no enclave)

~$ docker run -it --network host \
    -v ./output:/app/output --rm \
    coral-cli:latest /app/coral-cli validator keygen \
    --guardian-threshold 1 \
    --module-name 0x5055464645525f4d4f44554c455f300000000000000000000000000000000000 \
    --withdrawal-credentials 0x0100000000000000000000005ee9246f01e95c08ee767029c1d18765bb1779d0 \
    --guardian-pubkeys 0x049cc1fbaa3cffd3e4c1f935c47720d013938ccb822a9cbd20c5f09ab65ae8300e7986b6ce75e916d3b59599ece72134adf2972d06a76a8ba5f3747d356117c342 \
    --fork-version 0x01017000 \
    --password-file output/passwd.txt \
    --output-file output/registration_docker_001.json

@kamiyaa kamiyaa force-pushed the clean-deps branch 2 times, most recently from e977513 to 0806c59 Compare March 27, 2024 20:52
@JasonVranek JasonVranek merged commit f676ffd into main Mar 27, 2024
1 check passed
@JasonVranek JasonVranek deleted the clean-deps branch March 27, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonVranek JasonVranek JasonVranek approved these changes

@lean-apple lean-apple Awaiting requested review from lean-apple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamiyaa @JasonVranek